Skip to content

Updated the Airtable app doc #5428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jun 3, 2025
Merged

Updated the Airtable app doc #5428

merged 11 commits into from
Jun 3, 2025

Conversation

@amee-sumo
Copy link
Collaborator

@amee-sumo amee-sumo commented Jun 2, 2025 •
edited
Loading

Purpose of this pull request

This pull request is to update the Airtable app doc with new content in the log collection, dashboard, and monitors section.

Select the type of change

  • Minor Changes - Typos, formatting, slight revisions
  • Update Content - Revisions, updating sections
  • New Content - New features, sections, pages, tutorials
  • Site and Tools - .clabot, version updates, maintenance, dependencies, new packages for the site (Docusaurus, Gatsby, React, etc.)

Ticket (if applicable)

https://sumologic.atlassian.net/browse/DOCS-904

@amee-sumo amee-sumo self-assigned this Jun 2, 2025
@amee-sumo amee-sumo requested review from a team, JV0812, jpipkin1, kimsauce and mafsumo as code owners June 2, 2025 14:57
@amee-sumo amee-sumo added doc:update Revisions and updates to content do-not-merge Pull requests that should not be merged labels Jun 2, 2025
@cla-bot cla-bot bot added the cla-signed Contributor approved, listed in .clabot file label Jun 2, 2025
@jpipkin1
Copy link
Collaborator

jpipkin1 commented Jun 2, 2025

Approved, @amee-sumo. But I'm not sure why the package.json and yarn.lock files are updated by this PR, when they should have only been updated by PR #5420. Maybe @kimsauce can tell us.

@kimsauce
Copy link
Collaborator

kimsauce commented Jun 2, 2025

Approved, @amee-sumo. But I'm not sure why the package.json and yarn.lock files are updated by this PR, when they should have only been updated by PR #5420. Maybe @kimsauce can tell us.

That's strange. While it doesn't hurt anything because there’s no 3.8.1 or newer yet, it could cause unpredictable changes later. @amee-sumo , I'd remove the ^ and pin versions exactly. You can...

  1. Manually remove the ^ from each @docusaurus/* line in package.json.
  2. Run rm yarn.lock && yarn install to regenerate the yarn.lock file.

@amee-sumo
Copy link
Collaborator Author

amee-sumo commented Jun 3, 2025

Approved, @amee-sumo. But I'm not sure why the package.json and yarn.lock files are updated by this PR, when they should have only been updated by PR #5420. Maybe @kimsauce can tell us.

That's strange. While it doesn't hurt anything because there’s no 3.8.1 or newer yet, it could cause unpredictable changes later. @amee-sumo , I'd remove the ^ and pin versions exactly. You can...

  1. Manually remove the ^ from each @docusaurus/* line in package.json.
  2. Run rm yarn.lock && yarn install to regenerate the yarn.lock file.

I made a commit with the required changes @kimsauce @jpipkin1. Please acknowledge if we are good to merge this PR.

@jpipkin1
Copy link
Collaborator

jpipkin1 commented Jun 3, 2025

@amee-sumo, I checked the PR, but still saw the package.json and yarn.lock files there. So I fixed the package.json file. But when I tried to remove and regenerate the yarn.lock file using Kim's command, the yarn.lock file still ended up appearing on the PR.

At this point, I recommend closing this PR and making a fresh one with your changes to the Airtable app article.

@kimsauce
Copy link
Collaborator

kimsauce commented Jun 3, 2025

@amee-sumo, I checked the PR, but still saw the package.json and yarn.lock files there. So I fixed the package.json file. But when I tried to remove and regenerate the yarn.lock file using Kim's command, the yarn.lock file still ended up appearing on the PR.

At this point, I recommend closing this PR and making a fresh one with your changes to the Airtable app article.

@amee-sumo @jpipkin1 All good! I just reverted the yarn.lock to what it is now.

@jpipkin1
Copy link
Collaborator

jpipkin1 commented Jun 3, 2025

Thanks, @kimsauce!

@amee-sumo amee-sumo added this pull request to the merge queue Jun 3, 2025
Merged via the queue into main with commit 350db6b Jun 3, 2025
7 checks passed
@amee-sumo amee-sumo deleted the update-airtable-app-doc branch June 3, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kimsauce kimsauce kimsauce approved these changes

@jpipkin1 jpipkin1 jpipkin1 approved these changes

@JV0812 JV0812 Awaiting requested review from JV0812 JV0812 is a code owner

@mafsumo mafsumo Awaiting requested review from mafsumo mafsumo is a code owner

Assignees

@amee-sumo amee-sumo

Labels

cla-signed Contributor approved, listed in .clabot file do-not-merge Pull requests that should not be merged doc:update Revisions and updates to content

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@amee-sumo @jpipkin1 @kimsauce